Fix #1580 Read symlinks for mysql commands that are deprecated in MariaDB 11#1650
Closed
ajdelgado wants to merge 2 commits intopuppetlabs:mainfrom
Closed
Fix #1580 Read symlinks for mysql commands that are deprecated in MariaDB 11#1650ajdelgado wants to merge 2 commits intopuppetlabs:mainfrom
ajdelgado wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
ajdelgado
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
|
Antonio J. Delgado seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
MariaDB 11 is deprecating compatibility with MySQL commands. The deprecation message get in between the output while running this commands breaking providers. See more details in Issue #1580
As one of my first attempts to Ruby (sorry if the code is not up to standards), I added some test to check if the commands are actually symlinks and in that case read them and use the target.
Probably the code shouldn't take the stderr merge with stdout, and that would solve the issue. Also a version check could help indicate the specific command to run. But I thought that it was cleaner and covering future possible cases by just reading the symlink and running the target command.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
#1580
Checklist
puppet apply)